jingz-db commented on code in PR #49488: URL: https://github.com/apache/spark/pull/49488#discussion_r1974452111
########## sql/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/streaming/TransformWithStateConnectSuite.scala: ########## Review Comment: > I've realized that you just ported the tests from python to Scala Exactly. I am porting python tests as connect Scala tests because Python tests are essentially end to end tests as well. > without leveraging better test framework. Would we just make this test suite be concise as much as possible rather than blind port? Unfortunately `StreamTest` and `MemoryStream` are not visible from connect/clinet/jvm directory we are currently using for connect related suites. You may find our other streaming tests are also end to end tests and did not make use of the StreamTest framework as well: https://github.com/apache/spark/blob/master/sql/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/streaming/FlatMapGroupsWithStateStreamingSuite.scala#L36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
