hvanhovell commented on code in PR #49488:
URL: https://github.com/apache/spark/pull/49488#discussion_r1978045536


##########
sql/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/streaming/TransformWithStateConnectSuite.scala:
##########


Review Comment:
   @HeartSaVioR while I am not against creating a test harness for this, I do 
have to side with @jingz-db about this for now. In connect mode we essentially 
run integration/end-to-end tests. As such the tests themselves should focus 
more on the API, than on nitty gritty details (for which you need more 
control). We have work planned in Spark 4.1 to create a shared test harnass but 
that is unlikely to give you control you need.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to