chris-twiner commented on code in PR #50023:
URL: https://github.com/apache/spark/pull/50023#discussion_r1971723345
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/DeserializerBuildHelper.scala:
##########
@@ -458,7 +460,10 @@ object DeserializerBuildHelper {
Literal.create(provider(), ObjectType(classOf[Codec[_, _]])),
"decode",
ObjectType(tag.runtimeClass),
- createDeserializer(encoder, path, walkedTypePath) :: Nil)
+ createDeserializer(encoder, path, walkedTypePath) :: Nil,
+ propagateNull = enc.nullable,
Review Comment:
it's possible I just added for symmetry, it doesn't have an effect on the
Spark test cases, I'll report back in a couple of hours if it affects any
frameless ones - either adding a test to cover those two lines or reverting
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
