chris-twiner commented on code in PR #50023:
URL: https://github.com/apache/spark/pull/50023#discussion_r1971629784
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SerializerBuildHelper.scala:
##########
@@ -429,7 +430,10 @@ object SerializerBuildHelper {
Literal(codecProvider(), ObjectType(classOf[Codec[_, _]])),
"encode",
externalDataTypeFor(encoder),
- input :: Nil)
+ input :: Nil,
Review Comment:
I replaced the duplicative test with an explicit test for
TransformingEncoder.nullable the catchily named "Encoder with OptionEncoder of
transformation". Encoding itself "works" but the output is incorrect with
Some(null) vs None. (NB in frameless this equates to 15 test failures)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
