miland-db commented on code in PR #49726:
URL: https://github.com/apache/spark/pull/49726#discussion_r1953048060
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -329,6 +376,32 @@ class AstBuilder extends DataTypeAstBuilder
.duplicateConditionInScope(CurrentOrigin.get,
condition.conditionName)
}
conditions += condition.conditionName -> condition.sqlState
+ case signalStatement: SignalStatement if
signalStatement.sqlState.isEmpty =>
Review Comment:
I can add `assert` but conditions are read from the statement itself. It is
either defined in the statement like `SIGNAL CONDITION_X` or if you use `SIGNAL
SQLSTATE '12345'` then it is `USER_RAISED_EXCEPTION`. What I can do is set the
condition to be `String` and not `Option[String]`. How that sounds?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
