miland-db commented on code in PR #49726:
URL: https://github.com/apache/spark/pull/49726#discussion_r1952801745
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -329,6 +376,32 @@ class AstBuilder extends DataTypeAstBuilder
.duplicateConditionInScope(CurrentOrigin.get,
condition.conditionName)
}
conditions += condition.conditionName -> condition.sqlState
+ case signalStatement: SignalStatement if
signalStatement.sqlState.isEmpty =>
Review Comment:
This is not what we want because error condition is defined for statements
like `SIGNAL SQLSTATE '12345';`. For statements like this errorCondition is
defined and we don't need to resolve sqlstate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
