miland-db commented on code in PR #49726: URL: https://github.com/apache/spark/pull/49726#discussion_r1952815202
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/SqlScriptingLogicalPlans.scala: ########## @@ -405,3 +406,34 @@ case class ExceptionHandler( handlerType) } } + +/** + * Logical operator for Signal Statement. + * @param isBuiltinError Flag indicating if the error is a builtin error. + * @param errorCondition Name of the error condition of the exception that will be thrown. + * @param sqlState SQL State for error that will be thrown. + * @param message Error message (either string or variable name). + * @param messageArguments Arguments to fill builtin error message placeholders. + */ +case class SignalStatement( + var isBuiltinError: Boolean = false, + errorCondition: Option[String] = None, + var sqlState: Option[String] = None, + message: Either[String, UnresolvedAttribute], Review Comment: It was done this way for execute immediate. Are there any advantages in using `Expression`? If message is literal it is resolved in `AstBuilder`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org