HeartSaVioR commented on code in PR #49488:
URL: https://github.com/apache/spark/pull/49488#discussion_r1947269032
##########
sql/connect/common/src/main/scala/org/apache/spark/sql/connect/KeyValueGroupedDataset.scala:
##########
@@ -142,28 +145,52 @@ class KeyValueGroupedDataset[K, V] private[sql] ()
extends sql.KeyValueGroupedDa
statefulProcessor: StatefulProcessor[K, V, U],
timeMode: TimeMode,
outputMode: OutputMode): Dataset[U] =
- unsupported()
+ transformWithStateHelper(statefulProcessor, timeMode, outputMode)
/** @inheritdoc */
private[sql] def transformWithState[U: Encoder, S: Encoder](
statefulProcessor: StatefulProcessorWithInitialState[K, V, U, S],
timeMode: TimeMode,
outputMode: OutputMode,
initialState: sql.KeyValueGroupedDataset[K, S]): Dataset[U] =
- unsupported()
+ transformWithStateHelper(
+ statefulProcessor.asInstanceOf[StatefulProcessor[K, V, U]],
+ timeMode,
+ outputMode,
+ Some(initialState))
/** @inheritdoc */
override private[sql] def transformWithState[U: Encoder](
statefulProcessor: StatefulProcessor[K, V, U],
eventTimeColumnName: String,
- outputMode: OutputMode): Dataset[U] = unsupported()
+ outputMode: OutputMode): Dataset[U] =
+ transformWithStateHelper(
+ statefulProcessor,
+ TimeMode.EventTime(),
+ outputMode,
+ eventTimeColumnName = eventTimeColumnName)
/** @inheritdoc */
override private[sql] def transformWithState[U: Encoder, S: Encoder](
statefulProcessor: StatefulProcessorWithInitialState[K, V, U, S],
eventTimeColumnName: String,
outputMode: OutputMode,
- initialState: sql.KeyValueGroupedDataset[K, S]): Dataset[U] =
unsupported()
+ initialState: sql.KeyValueGroupedDataset[K, S]): Dataset[U] =
+ transformWithStateHelper(
+ statefulProcessor,
+ TimeMode.EventTime(),
+ outputMode,
+ Some(initialState),
+ eventTimeColumnName)
+
+ // This is an interface, and it should not be used. The real implementation
is in the
+ // inherited class.
+ private[sql] def transformWithStateHelper[U: Encoder, S: Encoder](
+ statefulProcessor: StatefulProcessor[K, V, U],
+ timeMode: TimeMode,
+ outputMode: OutputMode,
+ initialState: Option[sql.KeyValueGroupedDataset[K, S]] = None,
+ eventTimeColumnName: String = ""): Dataset[U] = unsupported()
Review Comment:
OK I have no idea but if this was used by FMGWS then let's keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
