jingz-db commented on code in PR #49488: URL: https://github.com/apache/spark/pull/49488#discussion_r1947004569
########## sql/connect/common/src/main/protobuf/spark/connect/relations.proto: ########## @@ -1031,6 +1033,30 @@ message GroupMap { // (Optional) The schema for the grouped state. optional DataType state_schema = 10; + + // Below fields are only used by TransformWithState + // (Optional) TransformWithState related parameters. + optional TransformWithStateInfo transformWithStateInfo = 11; +} + +// Event time rule needed for chaining of operator of TransformWithState +message UpdateEventTimeWatermarkColumn { + // (Required) Input relation. + Relation input = 1; + + // (Required) Event time column name. + string event_time_col_name = 3; +} + +message TransformWithStateInfo { + // (Required) Bytes for java serialized user-defined stateful processor. Review Comment: >Just to confirm, will we use different message for Python version? I am planning to have different proto schema for Python because Python API is different so the proto message is different. I'll add a comment here saying this is only used for Scala. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org