LuciferYang commented on code in PR #49695: URL: https://github.com/apache/spark/pull/49695#discussion_r1934101007
########## dev/protobuf-breaking-changes-check.sh: ########## @@ -35,7 +35,7 @@ fi pushd sql/connect/common/src/main && echo "Start protobuf breaking changes checking against $BRANCH" && -buf breaking --against "https://github.com/apache/spark.git#branch=$BRANCH,subdir=connector/connect/common/src/main"; && +buf breaking --against "https://github.com/apache/spark.git#branch=$BRANCH,subdir=sql/connect/common/src/main"; && Review Comment: It shouldn't be used in GitHub Actions, because GitHub Actions uses the following configuration: https://github.com/apache/spark/blob/6bbfa2dad8c70b94ca52eb7cddde5ec68efbe0b1/.github/workflows/build_and_test.yml#L752-L756 Judging from the commit history, this seems more like a tool for local use by developers? It would be best to have @grundprinzip, @HyukjinKwon , or @zhengruifeng , who have modified this file, confirm it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
