LuciferYang commented on code in PR #49695: URL: https://github.com/apache/spark/pull/49695#discussion_r1934004174
########## dev/protobuf-breaking-changes-check.sh: ########## @@ -35,7 +35,7 @@ fi pushd sql/connect/common/src/main && echo "Start protobuf breaking changes checking against $BRANCH" && -buf breaking --against "https://github.com/apache/spark.git#branch=$BRANCH,subdir=connector/connect/common/src/main"; && +buf breaking --against "https://github.com/apache/spark.git#branch=$BRANCH,subdir=sql/connect/common/src/main"; && Review Comment: Should we perform a branch version check here? If `BRANCH` is branch-3.x, should we keep comparing it with `connector/connect/common/src/main` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
