LuciferYang commented on PR #49695: URL: https://github.com/apache/spark/pull/49695#issuecomment-2621813374
There may still be some code that needs to be fixed: https://github.com/apache/spark/blob/6bbfa2dad8c70b94ca52eb7cddde5ec68efbe0b1/sql/connect/server/README.md?plain=1#L4 https://github.com/apache/spark/blob/6bbfa2dad8c70b94ca52eb7cddde5ec68efbe0b1/sql/connect/common/README.md?plain=1#L4 https://github.com/apache/spark/blob/6bbfa2dad8c70b94ca52eb7cddde5ec68efbe0b1/docs/spark-connect-overview.md?plain=1#L250 https://github.com/apache/spark/blob/6bbfa2dad8c70b94ca52eb7cddde5ec68efbe0b1/docs/_plugins/build_api_docs.rb#L149-L156 https://github.com/apache/spark/blob/6bbfa2dad8c70b94ca52eb7cddde5ec68efbe0b1/dev/lint-scala#L37-L44 https://github.com/apache/spark/blob/6bbfa2dad8c70b94ca52eb7cddde5ec68efbe0b1/.github/labeler.yml#L222-L227 https://github.com/apache/spark/blob/6bbfa2dad8c70b94ca52eb7cddde5ec68efbe0b1/dev/protobuf-breaking-changes-check.sh#L36-L39 https://github.com/apache/spark/blob/6bbfa2dad8c70b94ca52eb7cddde5ec68efbe0b1/dev/sparktestsupport/modules.py#L332-L343 @hvanhovell Could you please review the above file again? Of course, I don't object to fixing some of them in separate pull requests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
