pan3793 commented on code in PR #49564:
URL: https://github.com/apache/spark/pull/49564#discussion_r1931549904
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala:
##########
@@ -406,7 +406,7 @@ private case class MySQLDialect() extends JdbcDialect with
SQLConfHelper with No
}
options.prepareQuery +
- s"SELECT $columnList FROM ${options.tableOrQuery} $tableSampleClause" +
+ s"SELECT ${options.hint}$columnList FROM ${options.tableOrQuery}
$tableSampleClause" +
Review Comment:
Sorry for the late reply because of I am out of office these days.
@wayneguow as you mentioned, at least Oracle and MySQL also support hint
clauses to be present after INSERT/UPDATE/DELETE keywords, and some SQL
dialects like Flink SQL also use hint syntax for setting options for data
sources(e.g. `... FROM source /*+ hints */`). This PR adds a quite generic
option `hint` but only for select clauses and limits the scope for reading, I
would suggest using a specific name, e.g. `selectHint` instead of the generic
`hint`, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
