wayneguow commented on code in PR #49564:
URL: https://github.com/apache/spark/pull/49564#discussion_r1929917111
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala:
##########
@@ -228,8 +228,8 @@ private case class OracleDialect() extends JdbcDialect with
SQLConfHelper with N
extends JdbcSQLQueryBuilder(dialect, options) {
override def build(): String = {
- val selectStmt = s"SELECT $columnList FROM ${options.tableOrQuery}
$tableSampleClause" +
- s" $whereClause $groupByClause $orderByClause"
+ val selectStmt = s"SELECT $hintClause$columnList FROM
${options.tableOrQuery}" +
Review Comment:
Yes, that's my purpose. Only add a space at the end when hint is not empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
