dongjoon-hyun commented on code in PR #49564:
URL: https://github.com/apache/spark/pull/49564#discussion_r1929914236
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -980,6 +980,13 @@ private[sql] object QueryExecutionErrors extends
QueryErrorsBase with ExecutionE
messageParameters = Map("content" -> content))
}
+ def hintUnsupportedForJdbcDialectError(
+ jdbcDialect: String): SparkUnsupportedOperationException = {
+ new SparkUnsupportedOperationException(
Review Comment:
+1 for `SparkIllegalArgumentException` in this context, too.
`hintUnsupportedForJdbcDialectError` method name is proper, but
`SparkIllegalArgumentException` would be the correct error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
