stefankandic commented on code in PR #49103:
URL: https://github.com/apache/spark/pull/49103#discussion_r1903961212
##########
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##########
@@ -127,6 +128,17 @@ case object StringType
}
}
+/**
+ * String type that was the result of coercing two different non-explicit
collations.
+ */
+private[spark] case object IndeterminateStringType
+ extends StringType(CollationFactory.INDETERMINATE_COLLATION_ID) {
+
+ override def jsonValue: JValue = throw new SparkRuntimeException(
Review Comment:
I did this as a last resort to make sure we never serialize this type
successfully, but all existing tests should pass even without this change. Do
you have some ideas how to achieve this differently?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
