stefankandic commented on code in PR #49103: URL: https://github.com/apache/spark/pull/49103#discussion_r1899530458
########## sql/core/src/test/scala/org/apache/spark/sql/collation/IndeterminateCollationTestSuite.scala: ########## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.collation + +import org.apache.spark.{SparkRuntimeException, SparkThrowable} +import org.apache.spark.sql.{AnalysisException, DataFrame, QueryTest, Row} +import org.apache.spark.sql.test.SharedSparkSession +import org.apache.spark.sql.types.StringType + +class IndeterminateCollationTestSuite extends QueryTest with SharedSparkSession { + + val testTableName = "tst_table" + val dataSource = "parquet" + + def withTestTable(testCode: => Unit): Unit = { + withTable(testTableName) { + sql(s""" + |CREATE TABLE $testTableName ( + | c1 STRING COLLATE UTF8_LCASE, + | c2 STRING COLLATE UTF8_BINARY + |) USING $dataSource + |""".stripMargin) + testCode + } + } + + def assertIndeterminateCollationInExpressionError(query: => DataFrame): Unit = { + val exception = intercept[AnalysisException] { + query + } + assert(exception.getCondition === "INDETERMINATE_COLLATION_IN_EXPRESSION") + } + + def assertRuntimeIndeterminateCollationError(query: => DataFrame): Unit = { + val exception = intercept[SparkRuntimeException] { + query.collect() + } + assert(exception.getCondition === "INDETERMINATE_COLLATION") + } + + def assertIndeterminateCollationInSchemaError(columnPaths: String*)( + query: => DataFrame): Unit = { + checkError( + exception = intercept[AnalysisException] { + query.collect() + }, + condition = "INDETERMINATE_COLLATION_IN_SCHEMA", + parameters = Map("columnPaths" -> columnPaths.mkString(", "))) + } + + test("cannot use indeterminate collation name") { + checkError( + intercept[SparkThrowable] { + sql("SELECT 'a' COLLATE NULL") + }, + "COLLATION_INVALID_NAME", + parameters = Map("proposals" -> "nl", "collationName" -> "NULL")) + + checkError( + intercept[SparkThrowable] { + sql("SELECT CAST('a' AS STRING COLLATE NULL)") + }, + "COLLATION_INVALID_NAME", + parameters = Map("proposals" -> "nl", "collationName" -> "NULL")) + + intercept[SparkThrowable] { + StringType("NULL") + } + } + + test("various expressions that support indeterminate collation") { + withTestTable { + sql(s"INSERT INTO $testTableName VALUES ('a', 'b')") + + val expressions = Seq( + "c1 || c2", + "concat(c1, c2)", + "concat_ws(' ', c1, c2)", + "length(c1 || c2)", + "array(c1 || c2)", + "map('a', c1 || c2)", + "named_struct('f1', c1 || c2, 'f2', c2)", + "repeat(c1 || c2, 2)", + "elt(1, c1 || c2, c2)", + "coalesce(c1 || c2, c2)") + + expressions.foreach { expr => + sql(s"SELECT $expr FROM $testTableName").collect() + } + + checkAnswer(sql(s"SELECT COLLATION(c1 || c2) FROM $testTableName"), Seq(Row("null"))) + } + } + + test("expressions that don't support indeterminate collations and fail in analyzer") { + withTestTable { + sql(s"INSERT INTO $testTableName VALUES ('a', 'b')") + + val expressions = Seq( + "c1 = c2", + "c1 != c2", + "c1 > c2", + "STARTSWITH(c1 || c2, c1)", + "ENDSWITH(c1 || c2, c2)", + "UPPER(c1 || c2) = 'AB'", + "INITCAP(c1 || c2) = 'Ab'", + "FIND_IN_SET(c1 || c2, 'a,b')", + "INSTR(c1 || c2, c1)", + "LOCATE(c1, c1 || c2)") + + expressions.foreach { expr => + assertIndeterminateCollationInExpressionError { + sql(s"SELECT $expr FROM $testTableName") + } + } + } + } + + test("expressions that don't support indeterminate collation and fail in runtime") { + withTestTable { + sql(s"INSERT INTO $testTableName VALUES ('a', 'b')") + + val expressions = Seq("str_to_map(c1 || c2, 'a', 'b')") + + expressions.foreach { expr => + assertRuntimeIndeterminateCollationError { + sql(s"SELECT $expr FROM $testTableName") + } + } + } + } + + test("insert works with indeterminate collation") { + withTestTable { + sql(s""" + |INSERT INTO $testTableName + |SELECT c1 || c2, c2 || c1 + |FROM VALUES ('a', 'b') AS t(c1, c2) + |""".stripMargin) + + checkAnswer(sql(s"SELECT * FROM $testTableName"), Seq(Row("ab", "ba"))) + } + } + + test("create table as select fails with indeterminate collation") { + withTestTable { + assertIndeterminateCollationInSchemaError("concat(c1, c2)") { + sql(s""" + |CREATE TABLE t AS + |SELECT c1 || c2 FROM $testTableName + |""".stripMargin) + } + + assertIndeterminateCollationInSchemaError("col") { + sql(s""" + |CREATE TABLE t AS + |SELECT concat_ws(', ', c1, c2) as col FROM $testTableName + |""".stripMargin) + } + + assertIndeterminateCollationInSchemaError("arr.element", "map.value", "struct.f1")(sql(s""" + |CREATE TABLE t + |USING $dataSource + |AS SELECT + | array(c1 || c2) AS arr, + | map('a', c1 || c2) AS map, + | named_struct('f1', c1 || c2, 'f2', c2) AS struct + |FROM $testTableName + |""".stripMargin)) + } + } + + test("can create a view with indeterminate collation") { + withTestTable { + sql(s"INSERT INTO $testTableName VALUES ('a', 'b')") + sql(s"INSERT INTO $testTableName VALUES ('c', 'd')") + + withView("v") { + sql(s""" + |CREATE VIEW v AS + |SELECT c1 || c2 as col FROM $testTableName + |""".stripMargin) + + checkAnswer(sql("SELECT * FROM v"), Seq(Row("ab"), Row("cd"))) + checkAnswer(sql("SELECT DISTINCT COLLATION(col) FROM v"), Seq(Row("null"))) + + // group by should fail in runtime when fetching the collator + assertRuntimeIndeterminateCollationError { + sql(s"SELECT * FROM v GROUP BY col") + } Review Comment: View will not pick up the new schema if we alter the collation of the column. However we can add test for the happy path by just adding a collate clause in the group by. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
