stefankandic commented on code in PR #49103:
URL: https://github.com/apache/spark/pull/49103#discussion_r1899530341
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -1082,6 +1096,43 @@ static CollationMeta
loadCollationMeta(CollationIdentifier collationIdentifier)
}
}
+ /**
+ * Collation that is a result of two different non-explicit collation.
+ */
+ private static class IndeterminateCollation extends Collation {
+
+ IndeterminateCollation() {
+ super(
+ "null",
Review Comment:
Java doesn't support named parameters unfortunately, however intellij is
smart enough to add them in the UI
<img width="303" alt="image"
src="https://github.com/user-attachments/assets/bed0f55e-706a-4e9f-b5f2-8cf7d2b084b2";
/>
##########
sql/core/src/test/scala/org/apache/spark/sql/collation/IndeterminateCollationTestSuite.scala:
##########
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.collation
+
+import org.apache.spark.{SparkRuntimeException, SparkThrowable}
+import org.apache.spark.sql.{AnalysisException, DataFrame, QueryTest, Row}
+import org.apache.spark.sql.test.SharedSparkSession
+import org.apache.spark.sql.types.StringType
+
+class IndeterminateCollationTestSuite extends QueryTest with
SharedSparkSession {
+
+ val testTableName = "tst_table"
+ val dataSource = "parquet"
+
+ def withTestTable(testCode: => Unit): Unit = {
+ withTable(testTableName) {
+ sql(s"""
+ |CREATE TABLE $testTableName (
+ | c1 STRING COLLATE UTF8_LCASE,
Review Comment:
I don't really see the benefit, we just want the two to be different, but
when it comes to their behavior this test suite should not really care
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
