anishshri-db commented on code in PR #49277:
URL: https://github.com/apache/spark/pull/49277#discussion_r1902167593
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateSchemaCompatibilityChecker.scala:
##########
@@ -163,25 +157,47 @@ class StateSchemaCompatibilityChecker(
private def check(
oldSchema: StateStoreColFamilySchema,
newSchema: StateStoreColFamilySchema,
- ignoreValueSchema: Boolean) : Unit = {
+ ignoreValueSchema: Boolean,
+ schemaEvolutionEnabled: Boolean): StateStoreColFamilySchema = {
+
+ def incrementSchemaId(id: Short): Short = (id + 1).toShort
+
+ // Initialize with old schema IDs
+ var resultSchema = newSchema.copy(
+ keySchemaId = oldSchema.keySchemaId,
+ valueSchemaId = oldSchema.valueSchemaId
+ )
val (storedKeySchema, storedValueSchema) = (oldSchema.keySchema,
oldSchema.valueSchema)
val (keySchema, valueSchema) = (newSchema.keySchema, newSchema.valueSchema)
if (storedKeySchema.equals(keySchema) &&
(ignoreValueSchema || storedValueSchema.equals(valueSchema))) {
// schema is exactly same
+ oldSchema
} else if (!schemasCompatible(storedKeySchema, keySchema)) {
throw
StateStoreErrors.stateStoreKeySchemaNotCompatible(storedKeySchema.toString,
keySchema.toString)
+ } else if (!ignoreValueSchema && schemaEvolutionEnabled) {
+ // Check value schema evolution
+ val oldAvroSchema =
SchemaConverters.toAvroTypeWithDefaults(storedValueSchema)
+ val newAvroSchema = SchemaConverters.toAvroTypeWithDefaults(valueSchema)
+
+ val validator = new
SchemaValidatorBuilder().canReadStrategy.validateAll()
Review Comment:
Also - if we throw an exception - is the error message clear to the user ?
is it actionable on what they need to do to fix the issue ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
