ericm-db commented on code in PR #49277: URL: https://github.com/apache/spark/pull/49277#discussion_r1902100925
########## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala: ########## @@ -82,11 +82,23 @@ private[sql] class RocksDBStateStoreProvider stateStoreName = stateStoreId.storeName, colFamilyName = colFamilyName) - val dataEncoder = getDataEncoder( - stateStoreEncoding, dataEncoderCacheKey, keyStateEncoderSpec, valueSchema) - val columnFamilyInfo = Some(ColumnFamilyInfo(colFamilyName, newColFamilyId)) + stateSchemaProvider match { + case Some(t: TestStateSchemaProvider) => Review Comment: Yeah - we need this or else the RocksDBStateStoreSuite with avro fails because the schema isn't in the provider -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org