ericm-db commented on code in PR #49277:
URL: https://github.com/apache/spark/pull/49277#discussion_r1902164189
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala:
##########
@@ -35,13 +35,19 @@ object TimerStateUtils {
val KEY_TO_TIMESTAMP_CF = "_keyToTimestamp"
val TIMESTAMP_TO_KEY_CF = "_timestampToKey"
- def getTimerStateVarName(timeMode: String): String = {
+ def getTimerStateVarNames(timeMode: String): (String, String) = {
assert(timeMode == TimeMode.EventTime.toString || timeMode ==
TimeMode.ProcessingTime.toString)
- if (timeMode == TimeMode.EventTime.toString) {
+ val primaryIndex = if (timeMode == TimeMode.EventTime.toString) {
Review Comment:
Oh I was trying to address this comment:
https://github.com/apache/spark/pull/49277#discussion_r1902067213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
