uros-db commented on code in PR #46078:
URL: https://github.com/apache/spark/pull/46078#discussion_r1568638560
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##########
@@ -130,6 +215,9 @@ object CollationBenchmark extends CollationBenchmarkBase {
benchmarkUTFStringEquals(collationTypes, generateSeqInput(10000L))
benchmarkUTFStringCompare(collationTypes, generateSeqInput(10000L))
benchmarkUTFStringHashFunction(collationTypes, generateSeqInput(10000L))
+ benchmarkUTFStringContains(collationTypes, generateSeqInput(10000L))
+ benchmarkUTFStringStartsWith(collationTypes, generateSeqInput(10000L))
+ benchmarkUTFStringEndsWith(collationTypes, generateSeqInput(10000L))
Review Comment:
I think `UTFStringContains` is not the best naming, we're not benchmarking
anything out of `UTFString` directly
maybe a better name would be something like `benchmarkCollationAwareContains`
(ditto below)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
