uros-db commented on code in PR #46078:
URL: https://github.com/apache/spark/pull/46078#discussion_r1568631300
##########
sql/core/benchmarks/CollationBenchmark-jdk21-results.txt:
##########
@@ -2,26 +2,53 @@ OpenJDK 64-Bit Server VM 21.0.2+13-LTS on Linux
6.5.0-1017-azure
AMD EPYC 7763 64-Core Processor
collation unit benchmarks - equalsFunction: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
--------------------------------------------------------------------------------------------------------------------------
-UTF8_BINARY_LCASE 6910 6912
3 0.0 69099.7 1.0X
-UNICODE 4367 4368
1 0.0 43669.6 1.6X
-UTF8_BINARY 4361 4364
4 0.0 43606.5 1.6X
-UNICODE_CI 46480 46526
66 0.0 464795.7 0.1X
+UTF8_BINARY_LCASE 6917 6918
1 0.0 69173.7 1.0X
+UNICODE 4354 4359
8 0.0 43539.4 1.6X
+UTF8_BINARY 4335 4338
4 0.0 43354.3 1.6X
+UNICODE_CI 44575 44582
9 0.0 445751.5 0.2X
OpenJDK 64-Bit Server VM 21.0.2+13-LTS on Linux 6.5.0-1017-azure
AMD EPYC 7763 64-Core Processor
collation unit benchmarks - compareFunction: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
---------------------------------------------------------------------------------------------------------------------------
-UTF8_BINARY_LCASE 6522 6526
4 0.0 65223.9 1.0X
-UNICODE 45792 45797
7 0.0 457922.3 0.1X
-UTF8_BINARY 7092 7112
29 0.0 70921.7 0.9X
-UNICODE_CI 47548 47564
22 0.0 475476.7 0.1X
+UTF8_BINARY_LCASE 7184 7201
25 0.0 71837.4 1.0X
+UNICODE 46620 46651
43 0.0 466199.7 0.2X
+UTF8_BINARY 7110 7115
7 0.0 71104.4 1.0X
+UNICODE_CI 47808 47835
37 0.0 478084.9 0.2X
OpenJDK 64-Bit Server VM 21.0.2+13-LTS on Linux 6.5.0-1017-azure
AMD EPYC 7763 64-Core Processor
collation unit benchmarks - hashFunction: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-UTF8_BINARY_LCASE 11716 11716
1 0.0 117157.9 1.0X
-UNICODE 180133 180137
5 0.0 1801332.1 0.1X
-UTF8_BINARY 10476 10477
1 0.0 104757.4 1.1X
-UNICODE_CI 148171 148190
28 0.0 1481705.6 0.1X
+UTF8_BINARY_LCASE 11380 11390
15 0.0 113795.1 1.0X
+UNICODE 176471 176477
9 0.0 1764709.9 0.1X
+UTF8_BINARY 10858 10859
1 0.0 108580.4 1.0X
+UNICODE_CI 153060 153161
143 0.0 1530598.1 0.1X
Review Comment:
I see that the benchmark runs on previous functions too, but we shouldn't
make any unnecessary modifications in this PR (that are not related to the
changes brought by this PR)
so I would advise keep the previous results as they were, and only append
yours below
##########
sql/core/benchmarks/CollationNonASCIIBenchmark-jdk21-results.txt:
##########
@@ -2,26 +2,53 @@ OpenJDK 64-Bit Server VM 21.0.2+13-LTS on Linux
6.5.0-1017-azure
AMD EPYC 7763 64-Core Processor
collation unit benchmarks - equalsFunction: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
--------------------------------------------------------------------------------------------------------------------------
-UTF8_BINARY_LCASE 18244 18258
20 0.0 456096.4 1.0X
-UNICODE 498 498
0 0.1 12440.3 36.7X
-UTF8_BINARY 499 500
1 0.1 12467.7 36.6X
-UNICODE_CI 13429 13443
19 0.0 335725.4 1.4X
+UTF8_BINARY_LCASE 18815 18847
45 0.0 470378.1 1.0X
+UNICODE 483 484
0 0.1 12085.0 38.9X
+UTF8_BINARY 483 489
11 0.1 12084.1 38.9X
+UNICODE_CI 15285 15287
3 0.0 382114.7 1.2X
OpenJDK 64-Bit Server VM 21.0.2+13-LTS on Linux 6.5.0-1017-azure
AMD EPYC 7763 64-Core Processor
collation unit benchmarks - compareFunction: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
---------------------------------------------------------------------------------------------------------------------------
-UTF8_BINARY_LCASE 18377 18399
31 0.0 459430.5 1.0X
-UNICODE 14238 14240
3 0.0 355957.4 1.3X
-UTF8_BINARY 975 976
1 0.0 24371.3 18.9X
-UNICODE_CI 13819 13826
10 0.0 345482.6 1.3X
+UTF8_BINARY_LCASE 18822 18831
13 0.0 470547.2 1.0X
+UNICODE 14491 14505
21 0.0 362268.8 1.3X
+UTF8_BINARY 980 981
1 0.0 24487.8 19.2X
+UNICODE_CI 14494 14524
43 0.0 362341.6 1.3X
OpenJDK 64-Bit Server VM 21.0.2+13-LTS on Linux 6.5.0-1017-azure
AMD EPYC 7763 64-Core Processor
collation unit benchmarks - hashFunction: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-UTF8_BINARY_LCASE 9183 9230
67 0.0 229564.0 1.0X
-UNICODE 38937 38952
22 0.0 973421.3 0.2X
-UTF8_BINARY 1376 1376
0 0.0 34397.5 6.7X
-UNICODE_CI 32881 32882
1 0.0 822027.4 0.3X
+UTF8_BINARY_LCASE 10768 10780
17 0.0 269199.8 1.0X
+UNICODE 42046 42062
23 0.0 1051138.9 0.3X
+UTF8_BINARY 1980 1984
5 0.0 49506.4 5.4X
+UNICODE_CI 33206 33212
7 0.0 830160.4 0.3X
Review Comment:
I see that the benchmark runs on previous functions too, but we shouldn't
make any unnecessary modifications in this PR (that are not related to the
changes brought by this PR)
so I would advise keep the previous results as they were, and only append
yours below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
