vladimirg-db commented on code in PR #46078:
URL: https://github.com/apache/spark/pull/46078#discussion_r1568305287
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##########
@@ -100,6 +100,90 @@ abstract class CollationBenchmarkBase extends
BenchmarkBase {
)
benchmark.run()
}
+
+ def benchmarkUTFStringContains(
+ collationTypes: Seq[String],
+ utf8Strings: Seq[UTF8String]): Unit = {
+ val sublistStrings = utf8Strings
+
+ val benchmark = new Benchmark(
+ "collation unit benchmarks - contains",
+ utf8Strings.size * 10,
+ warmupTime = 10.seconds,
+ output = output)
+ collationTypes.foreach(collationType => {
Review Comment:
Sure, I will also refactor the upper code here, since it has the same
structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]