----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review126496 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/xfs/utils.hpp (lines 45 - 47) <https://reviews.apache.org/r/44946/#comment189495> Sorry it didn't occur to to me earlier but looking at the tests I realized that we need to return a Result. i.e., ``` Result<QuotaInfo> getProjectQuota( const std::string& path, prid_t projectId); ``` because a zero limit is "no limit", hence `None`. We use `setProjectQuota` and `clearProjectQuota` to carefully spearate the two use cases so here I think it's justified to make zero quota a special type. (Plus we do this for `getProjectId()` already). - Jiang Yan Xu On March 31, 2016, 5:01 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44946/ > ----------------------------------------------------------- > > (Updated March 31, 2016, 5:01 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-4828 > https://issues.apache.org/jira/browse/MESOS-4828 > > > Repository: mesos > > > Description > ------- > > Add utility functions to manipulate XFS project quotas. > > > Diffs > ----- > > src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 > src/slave/containerizer/mesos/isolators/xfs/utils.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/xfs/utils.cpp PRE-CREATION > src/tests/environment.cpp 90dbe9488bda6af26143934e196aab0d69dccec3 > > Diff: https://reviews.apache.org/r/44946/diff/ > > > Testing > ------- > > Make check. Manual verification. Tests in subsequent patches. > > > Thanks, > > James Peach > >
