----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review127465 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/xfs/utils.cpp (line 58) <https://reviews.apache.org/r/44946/#comment190806> Nit: `static constexpr Bytes BASIC_BLOCK_SIZE = Bytes(512);` for consistency just because this is how constants in Mesos are generally constructed (copy constructed). - Jiang Yan Xu On April 6, 2016, 11:42 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44946/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 11:42 a.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-4828 > https://issues.apache.org/jira/browse/MESOS-4828 > > > Repository: mesos > > > Description > ------- > > Add utility functions to manipulate XFS project quotas. > > > Diffs > ----- > > src/Makefile.am 55d3b341361bed25f3aa966d77060c88be29e5b0 > src/slave/containerizer/mesos/isolators/xfs/utils.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/xfs/utils.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44946/diff/ > > > Testing > ------- > > Make check. Manual verification. Tests in subsequent patches. > > > Thanks, > > James Peach > >
