> On March 23, 2016, 10:39 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp, line 119 > > <https://reviews.apache.org/r/44946/diff/9/?file=1311203#file1311203line119> > > > > I know I asked this previoiusly but what's the difference between this > > and: > > > > ``` > > fs_disk_quota_t quota; > > ``` > > > > If it's the same, then the more common syntax is preferred because this > > syntax reads like the 1st member of the struct has special some > > meaning/usage. > > James Peach wrote: > This is a ``C`` zero-initialization. I can either do this or ``memset`` > the structure to zero, to get the same result.
Forgot this is a C struct. Alright. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review124248 ----------------------------------------------------------- On March 22, 2016, 4:24 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44946/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 4:24 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-4828 > https://issues.apache.org/jira/browse/MESOS-4828 > > > Repository: mesos > > > Description > ------- > > Add utility functions to manipulate XFS project quotas. > > > Diffs > ----- > > src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c > src/slave/containerizer/mesos/isolators/disk/xfs/utils.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44946/diff/ > > > Testing > ------- > > Make check. Manual verification. Tests in subsequent patches. > > > Thanks, > > James Peach > >
