> On March 25, 2016, 12:20 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 438 > > <https://reviews.apache.org/r/44706/diff/3/?file=1311930#file1311930line438> > > > > Why do you need to get os::environment()? > > Qian Zhang wrote: > The reason is, CNI plugin needs to call `iptables` to set up IPMasq, if > we do not do this, the plugin will fail with an error: > { > "code": 100, > "msg": "failed to locate iptables: exec: \"iptables\": executable > file not found in $PATH" > } > > Maybe we could explicitly set `$PATH` as > `/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin` rather than > call `os::environment()`?
Or you can only keep PATH in os::environment() and strip the rest. Please add a NOTE about that. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review125367 ----------------------------------------------------------- On March 26, 2016, 2:53 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44706/ > ----------------------------------------------------------- > > (Updated March 26, 2016, 2:53 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Implemented isolate() method of "network/cni" isolator. > > > Diffs > ----- > > src/CMakeLists.txt 7bda2ac684f38da94e334f0cef843614687ae4aa > src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > b1b7205f4f10b6dc256fcc4ecb3210105c1240b4 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 7cda5715814a0cfc4b394eb04437831e6dc44e3f > src/slave/containerizer/mesos/isolators/network/cni/paths.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni/paths.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44706/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
