> On March 21, 2016, 11:57 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 445 > > <https://reviews.apache.org/r/44706/diff/2/?file=1307515#file1307515line445> > > > > Why the `CHECK_READY` here ? If the future is not READY it could be in > > error, which is fine we should just return an ERROR ? > > Qian Zhang wrote: > Because when `NetworkCniIsolatorProcess::__connect` is called, we expect > `output` must be ready otherwise `NetworkCniIsolatorProcess::__connect` > should not be called. I think it is a common way to use `then`, please take a > look at: > https://github.com/apache/mesos/blob/0.28.0/src/slave/containerizer/mesos/isolators/network/port_mapping.cpp#L3173:L3186 > as a reference. > > Avinash sridharan wrote: > The fact that a plugin might misbehave should not cause the agent to > crash. I think this defensive check doesn't serve much purpose apart from > causing a potential panic in the Agent.
I have revised these code based on Jie's comments, so we do not need to call `CHECK_READY()` anymore. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review124554 ----------------------------------------------------------- On March 23, 2016, 10:22 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44706/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 10:22 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Implemented isolate() method of "network/cni" isolator. > > > Diffs > ----- > > src/CMakeLists.txt 0bd7a978306488b687a7e2eeeb8a5c9766d43548 > src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > 3878a7e85fe24175b3bd5e3a6268cf32a07f2d8b > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 9552312f9ba1e4df6564cfb737cc41e041cf4407 > src/slave/containerizer/mesos/isolators/network/cni/paths.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni/paths.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44706/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
