> On March 21, 2016, 11:57 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 471 > > <https://reviews.apache.org/r/44706/diff/2/?file=1307515#file1307515line471> > > > > Again why the CHECK ? The result might not have an IPv4 or an IPv6 > > allocation due to an IPAM error in which case we should return a failure. > > Qian Zhang wrote: > I think the output of IPAM plugin has no IPv4 address and no IPv6 address > is an unexpected result, so that's why I use `CHECK` here, but I agree with > you returning a `Failure` is more appropriate, will update the patch > accordingly later. > > Avinash sridharan wrote: > Why is it an unexpected result? What happens if the IPAM is > oversubscribed and runs out of addresses? That should definitely not cause > the Agent to crash. We should not be able to launch containers, but the Agent > should not be crashing. IPAM running out of addresses is not a terminal > behavior, it will recover when containers are destroyed and IP addresses are > freed.
Yes, I agree, let me remove that `CHECK`. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review124554 ----------------------------------------------------------- On March 21, 2016, 12:27 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44706/ > ----------------------------------------------------------- > > (Updated March 21, 2016, 12:27 a.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Implemented isolate() method of "network/cni" isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44706/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
