----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35152/#review87049 -----------------------------------------------------------
Ship it! Nice comments! Please adjust the comments as I suggested. We can chat if you don't understand what I was talking about. Otherwise, LGTM! src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35152/#comment139311> for [7] and [10], I would move the arrow at [7] to veth0 src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35152/#comment139312> For [8] and [9], I would use a double ended arrow <--> and move the arrow at [8] to mesosNNNN. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35152/#comment139309> Kill this line. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35152/#comment139308> 2 lines above src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35152/#comment139310> Please adjust the format. Notice that there is a 'script' in the end. - Jie Yu On June 8, 2015, 4:35 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35152/ > ----------------------------------------------------------- > > (Updated June 8, 2015, 4:35 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: MESOS-2821 > https://issues.apache.org/jira/browse/MESOS-2821 > > > Repository: mesos > > > Description > ------- > > Document and consolidate qdisc handles > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.cpp > 871e9cf1625d96d1feef50edd4081972c097d191 > > Diff: https://reviews.apache.org/r/35152/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
