----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35152/#review86856 -----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35152/#comment138965> Somewhere we should mention icmp and arp are mirrored, but ip traffic is redirected, which takes precedence than the former two in filtering. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35152/#comment138961> Should be more clear that this is inside the container. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35152/#comment138969> "reduce performance interference" seems a bit too general to me. Can we touch a bit on the specifics such as "each container's outbound traffic is given a separate flow, and also the catch-all flow for traffic originated from host and everything else", etc - Chi Zhang On June 5, 2015, 10:35 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35152/ > ----------------------------------------------------------- > > (Updated June 5, 2015, 10:35 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: MESOS-2821 > https://issues.apache.org/jira/browse/MESOS-2821 > > > Repository: mesos > > > Description > ------- > > Document and consolidate qdisc handles > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.cpp > 871e9cf1625d96d1feef50edd4081972c097d191 > > Diff: https://reviews.apache.org/r/35152/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
