----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35152/#review86843 -----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35152/#comment138941> s/connection/interface/ src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35152/#comment138939> s/data/packet/ src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35152/#comment138940> s/policies/filters/ src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35152/#comment138937> s/interface qdisc/qdisc/ src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35152/#comment138938> Nit: there could be more than one filters since we could have more than one port ranges for each container. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35152/#comment138931> What is "filter chain"?? There is no such thing in TC. Also we don't have any filter on htb. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35152/#comment138932> Ditto, there is no filter here, just a class. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35152/#comment138933> The fq_codel qdisc here is for reducing buffer-bloat, not traffic shaping. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35152/#comment138934> s/FInally/Finally/ src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35152/#comment138935> Ditto, the fq_codel here is for traffic isolation and reducing buffer-bloat. - Cong Wang On June 5, 2015, 8:38 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35152/ > ----------------------------------------------------------- > > (Updated June 5, 2015, 8:38 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: MESOS-2821 > https://issues.apache.org/jira/browse/MESOS-2821 > > > Repository: mesos > > > Description > ------- > > Document and consolidate qdisc handles > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.cpp > 871e9cf1625d96d1feef50edd4081972c097d191 > > Diff: https://reviews.apache.org/r/35152/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
