Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/23815 )
Change subject: IMPALA-14085: Implement GRANT/REVOKE ROLE TO/FROM a user ...................................................................... Patch Set 6: (2 comments) I have addressed Csaba's comments on patch set 5. Let me know if there are additional suggestions. Thanks! http://gerrit.cloudera.org:8080/#/c/23815/5/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: http://gerrit.cloudera.org:8080/#/c/23815/5/common/thrift/JniCatalog.thrift@744 PS5, Line 744: 3: required bool is_grant : > Can you add a comment about the relation of group_names and user_names? Sure. I will add a comment about the relation in the next patch. http://gerrit.cloudera.org:8080/#/c/23815/5/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/23815/5/tests/authorization/test_ranger.py@1688 PS5, Line 1688: # os.environ['GRANTEE_TYPE'] = grantee_type : # os.environ['GRANTEE_NAME'] = getuser > Can't we use run_test_case's test_file_vars for this? You are right. In the next patch I will make use of test_file_vars to pass the variables. -- To view, visit http://gerrit.cloudera.org:8080/23815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5a16aeb4bbf8637ad326a1ec3d5fce1b196d73f Gerrit-Change-Number: 23815 Gerrit-PatchSet: 6 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 14 Jan 2026 22:46:48 +0000 Gerrit-HasComments: Yes
