Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/23815 )
Change subject: IMPALA-14085: Implement GRANT/REVOKE ROLE TO/FROM a user ...................................................................... Patch Set 5: (1 comment) I have addressed Csaba's comment on patch set 4 by removing the field of 'principal_is_group' from TGrantRevokeRoleParams and revised the commit message accordingly. Please let me know if there are additional suggestions. Thanks! http://gerrit.cloudera.org:8080/#/c/23815/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23815/4//COMMIT_MSG@15 PS4, Line 15: Testing: : - Extended the test file grant_revoke.test to additionally cover the : scenario in which the grantee/re > > Why not use user_names's nullness for this? If that is null, then it shou Done -- To view, visit http://gerrit.cloudera.org:8080/23815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5a16aeb4bbf8637ad326a1ec3d5fce1b196d73f Gerrit-Change-Number: 23815 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 13 Jan 2026 23:07:28 +0000 Gerrit-HasComments: Yes
