Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23815 )
Change subject: IMPALA-14085: Implement GRANT/REVOKE ROLE TO/FROM a user ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/23815/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23815/4//COMMIT_MSG@15 PS4, Line 15: Note that we added an optional bool field 'principal_is_group' to : TGrantRevokeRoleParams that is used to encode the related parameters : for the GRANT/REVOKE ROLE command. Why not use user_names's nullness for this? If that is null, then it should be a group. If principal_is_group is kept then its default value should be true to interpret this RPC correctly in an old coordinator -> new catalogd scenario. -- To view, visit http://gerrit.cloudera.org:8080/23815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5a16aeb4bbf8637ad326a1ec3d5fce1b196d73f Gerrit-Change-Number: 23815 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 13 Jan 2026 16:00:54 +0000 Gerrit-HasComments: Yes
