Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23816 )
Change subject: IMPALA-9935: Support individual partitions in catalog_object webUI page ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/23816/2/be/src/catalog/catalog-util.cc File be/src/catalog/catalog-util.cc: http://gerrit.cloudera.org:8080/#/c/23816/2/be/src/catalog/catalog-util.cc@186 PS2, Line 186: if (dot_pos == string::npos || dot_pos >= object_name.size() - 1 : || colon_pos == string::npos || colon_pos >= object_name.size() - 1 : || colon_pos <= dot_pos || dot_pos == 0 > Nit: These lines should be formatted with the || at the beginning of the li Done http://gerrit.cloudera.org:8080/#/c/23816/2/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogTest.java: http://gerrit.cloudera.org:8080/#/c/23816/2/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@1077 PS2, Line 1077: HdfsTable table = (HdfsTable) catalog_.getOrLoadTable("functional", "alltypes", > This test is very thorough! Two missing cases: Thanks for identifying the missing cases. Done http://gerrit.cloudera.org:8080/#/c/23816/2/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@1226 PS2, Line 1226: * Test IMPALA-9935: Invalid partition key name. > The special character appears to be the underscore in the table name. If t Well actually the special character is "-" present in the partition column of date_tbl. eg: "date_part=1970-01-01" http://gerrit.cloudera.org:8080/#/c/23816/2/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@1272 PS2, Line 1272: > Is it possible to test the scenario where an IncompleteTable is loaded resu Done -- To view, visit http://gerrit.cloudera.org:8080/23816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5645a20283e664af12d04a9665c8870c7666a74c Gerrit-Change-Number: 23816 Gerrit-PatchSet: 3 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 08 Jan 2026 15:36:57 +0000 Gerrit-HasComments: Yes
