Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23816 )
Change subject: IMPALA-9935: Support individual partitions in catalog_object webUI page ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/23816/1/be/src/catalog/catalog-util.cc File be/src/catalog/catalog-util.cc: http://gerrit.cloudera.org:8080/#/c/23816/1/be/src/catalog/catalog-util.cc@186 PS1, Line 186: if (dot_pos == string::npos || dot_pos >= object_name.size() - 1 || : colon_pos == string::npos || colon_pos >= object_name.size() - 1 || : colon_pos <= dot_pos || > Done Done http://gerrit.cloudera.org:8080/#/c/23816/2/be/src/catalog/catalog-util.cc File be/src/catalog/catalog-util.cc: http://gerrit.cloudera.org:8080/#/c/23816/2/be/src/catalog/catalog-util.cc@186 PS2, Line 186: if (dot_pos == string::npos || dot_pos >= object_name.size() - 1 || : colon_pos == string::npos || colon_pos >= object_name.size() - 1 || : colon_pos <= dot_pos || dot_pos == 0) { Nit: These lines should be formatted with the || at the beginning of the line like: if (dot_pos == string::npos || dot_pos >= object_name.size() - 1 || colon_pos == string::npos || colon_pos >= object_name.size() - 1 || colon_pos <= dot_pos || dot_pos == 0) { http://gerrit.cloudera.org:8080/#/c/23816/1/fe/src/main/java/org/apache/impala/catalog/Catalog.java File fe/src/main/java/org/apache/impala/catalog/Catalog.java: http://gerrit.cloudera.org:8080/#/c/23816/1/fe/src/main/java/org/apache/impala/catalog/Catalog.java@1006 PS1, Line 1006: private static List<TPartitionKeyValue> parsePartitionName( > Done Done http://gerrit.cloudera.org:8080/#/c/23816/2/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogTest.java: http://gerrit.cloudera.org:8080/#/c/23816/2/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@1077 PS2, Line 1077: public void testGetPartitionCatalogObject() throws CatalogException { This test is very thorough! Two missing cases: 1. CatalogException should be thrown when table is not found 2. Exception when too many partitions specified such as -- "year=2010/month=12/day=1") Additionally, this single test is too long. Each of the test cases should be in its own JUnit test. http://gerrit.cloudera.org:8080/#/c/23816/2/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@1226 PS2, Line 1226: public void testGetPartitionWithSpecialCharacters() throws CatalogException { The special character appears to be the underscore in the table name. If that is the case, this test can be eliminated by using a table with an underscore in its name in another unit test. http://gerrit.cloudera.org:8080/#/c/23816/2/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@1272 PS2, Line 1272: public void testGetPartitionFromIncompleteTable() throws CatalogException { Is it possible to test the scenario where an IncompleteTable is loaded resulting in the "failed to load" CatalogException? -- To view, visit http://gerrit.cloudera.org:8080/23816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5645a20283e664af12d04a9665c8870c7666a74c Gerrit-Change-Number: 23816 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 07 Jan 2026 17:52:31 +0000 Gerrit-HasComments: Yes
