Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23816 )
Change subject: IMPALA-9935: Support individual partitions in catalog_object webUI page ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/23816/1/be/src/catalog/catalog-util.cc File be/src/catalog/catalog-util.cc: http://gerrit.cloudera.org:8080/#/c/23816/1/be/src/catalog/catalog-util.cc@186 PS1, Line 186: if (dot_pos == string::npos || dot_pos >= object_name.size() - 1 || : colon_pos == string::npos || colon_pos >= object_name.size() - 1 || : colon_pos <= dot_pos || > Also check if dot_pos == 0 in case the provided object_name is similar to " Done http://gerrit.cloudera.org:8080/#/c/23816/1/fe/src/main/java/org/apache/impala/catalog/Catalog.java File fe/src/main/java/org/apache/impala/catalog/Catalog.java: http://gerrit.cloudera.org:8080/#/c/23816/1/fe/src/main/java/org/apache/impala/catalog/Catalog.java@1006 PS1, Line 1006: private static List<TPartitionKeyValue> parsePartitionName( > Please add JUnit tests for this function in CatalogTest.java. Done -- To view, visit http://gerrit.cloudera.org:8080/23816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5645a20283e664af12d04a9665c8870c7666a74c Gerrit-Change-Number: 23816 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 06 Jan 2026 06:58:33 +0000 Gerrit-HasComments: Yes
