Xuebin Su has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23719 )

Change subject: IMPALA-14576, IMPALA-14577: add rewrite rules for geospatial 
relations
......................................................................


Patch Set 8: Code-Review+1

(2 comments)

Thanks!

http://gerrit.cloudera.org:8080/#/c/23719/5/fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java
File fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java:

http://gerrit.cloudera.org:8080/#/c/23719/5/fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java@53
PS5, Line 53:     nonIdempotentRules_ = nonIdempotentRules;
> Renamed the member
Done


http://gerrit.cloudera.org:8080/#/c/23719/5/fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java@72
PS5, Line 72:       while (oldNumChanges == numChanges_
> Changed logic to use a single while loop.
Done



--
To view, visit http://gerrit.cloudera.org:8080/23719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id65f646db6f1c89a74253e9ff755c39c400328be
Gerrit-Change-Number: 23719
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Xuebin Su <[email protected]>
Gerrit-Comment-Date: Thu, 18 Dec 2025 07:42:19 +0000
Gerrit-HasComments: Yes

Reply via email to