Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/23719 )
Change subject: WIP IMPALA-14576, IMPALA-14577: add rewrite rules for geospatial relations ...................................................................... Patch Set 5: (2 comments) Hi! http://gerrit.cloudera.org:8080/#/c/23719/5/fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java File fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java: http://gerrit.cloudera.org:8080/#/c/23719/5/fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java@53 PS5, Line 53: inferredPredicateRules_ = inferredPredicateRules; How about calling them "non-idempotent rules"? http://gerrit.cloudera.org:8080/#/c/23719/5/fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java@72 PS5, Line 72: // Apply inferredPredicateRules_ only once as these add predicates without removing Could we avoid writing the while loop for applying the rules_ twice by applying the inferredPredicateRules_ first? -- To view, visit http://gerrit.cloudera.org:8080/23719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id65f646db6f1c89a74253e9ff755c39c400328be Gerrit-Change-Number: 23719 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Tue, 09 Dec 2025 08:41:26 +0000 Gerrit-HasComments: Yes
