Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23719 )
Change subject: IMPALA-14576, IMPALA-14577: add rewrite rules for geospatial relations ...................................................................... Patch Set 11: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/23719/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23719/11//COMMIT_MSG@25 PS11, Line 25: st_intersects(geom1, geom2) What if users already wrote st_envintersects(geom1, geom2) AND st_intersects(geom1, geom2) to optimize their queries. Will it create st_envintersects(geom1, geom2) AND st_envintersects(geom1, geom2) AND st_intersects(geom1, geom2) http://gerrit.cloudera.org:8080/#/c/23719/8/fe/src/main/java/org/apache/impala/rewrite/PointEnvIntersectsRule.java File fe/src/main/java/org/apache/impala/rewrite/PointEnvIntersectsRule.java: http://gerrit.cloudera.org:8080/#/c/23719/8/fe/src/main/java/org/apache/impala/rewrite/PointEnvIntersectsRule.java@39 PS8, Line 39: st_envintersects(CONST_GEOM, st_point(x, y)) > This rule only makes sense for points. Ack http://gerrit.cloudera.org:8080/#/c/23719/11/fe/src/main/java/org/apache/impala/rewrite/PointEnvIntersectsRule.java File fe/src/main/java/org/apache/impala/rewrite/PointEnvIntersectsRule.java: http://gerrit.cloudera.org:8080/#/c/23719/11/fe/src/main/java/org/apache/impala/rewrite/PointEnvIntersectsRule.java@41 PS11, Line 41: * x >= st_minx(CONST_GEOM) AND y >= st_miny(CONST_GEOM) AND : * x <= st_maxx(CONST_GEOM) AND y <= st_maxy(CONST_GEOM) nit: You could mention that then st_minx(CONST_GEOM) and friends are further rewritten to const double values (by other rewriters). -- To view, visit http://gerrit.cloudera.org:8080/23719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id65f646db6f1c89a74253e9ff755c39c400328be Gerrit-Change-Number: 23719 Gerrit-PatchSet: 11 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 08 Jan 2026 09:47:13 +0000 Gerrit-HasComments: Yes
