Jason Fehr has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23781 )

Change subject: IMPALA-14284: Log the actual log files instead of symlinks in 
start-impala-cluster.py
......................................................................


Patch Set 3:

This change is great and very much needed, but my local testing is showing that 
it does not work when the cluster is started at the class level instead of at 
the function level.  For example, when I hard coded an assert failure in 
test_otel_trace.py test_select_timeout 
(https://github.com/apache/impala/blob/d4992d532b6fe12bce6dd12f0559b9899a547337/tests/custom_cluster/test_otel_trace.py#L166),
 it does not show the "Actual log file names" log messages even if I use the -k 
option to limit impala-py.test to only run test_select_timeout.


--
To view, visit http://gerrit.cloudera.org:8080/23781
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id76c0a8bdfb221ab24ee315e2e273abca4257398
Gerrit-Change-Number: 23781
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 16 Dec 2025 18:39:51 +0000
Gerrit-HasComments: No

Reply via email to