Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23781 )

Change subject: IMPALA-14284: Log the actual log files instead of symlinks in 
start-impala-cluster.py
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

Thanks for working on this, a great QOL improvement!

http://gerrit.cloudera.org:8080/#/c/23781/3/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:

http://gerrit.cloudera.org:8080/#/c/23781/3/bin/start-impala-cluster.py@1290
PS3, Line 1290:     if cluster_ops.log_symlinks:
> I'm interested in whether we could print anything useful if the cluster fai
Something like printing the last few fatal/error log lines seem useful, but 
probably worth some more thinking and a different patch. We could also identify 
or introduce some phases for different daemons, e.g. for impalad early startup 
/ waiting for JVM init / waiting for initial catalogd update, and print the 
last phase reached.



--
To view, visit http://gerrit.cloudera.org:8080/23781
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id76c0a8bdfb221ab24ee315e2e273abca4257398
Gerrit-Change-Number: 23781
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 16 Dec 2025 18:18:17 +0000
Gerrit-HasComments: Yes

Reply via email to