Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23781 )
Change subject: IMPALA-14284: Log the actual log files instead of symlinks in start-impala-cluster.py ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23781/3/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/23781/3/bin/start-impala-cluster.py@1290 PS3, Line 1290: if cluster_ops.log_symlinks: I'm interested in whether we could print anything useful if the cluster fails to start up, but it's probably not as an important a case to handle. http://gerrit.cloudera.org:8080/#/c/23781/3/bin/start-impala-cluster.py@1292 PS3, Line 1292: cluster_ops.log_symlinks > Would be nice to sort this. Right now they're in startup order, which I think also makes sense. -- To view, visit http://gerrit.cloudera.org:8080/23781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id76c0a8bdfb221ab24ee315e2e273abca4257398 Gerrit-Change-Number: 23781 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 16 Dec 2025 17:00:26 +0000 Gerrit-HasComments: Yes
