Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23700 )
Change subject: IMPALA-14573: port critical geospatial functions to c++ (part 1) ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/CMakeLists.txt File be/src/exprs/geo/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/CMakeLists.txt@29 PS8, Line 29: if (BUILD_WITH_NO_TESTS) > Why is this left in? The original patch had no IR files too: https://gerrit.cloudera.org/#/c/20602/6/be/src/exprs/geo/CMakeLists.txt I plan to add it back again, and keep only the most critical parts codegened. http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/common.h File be/src/exprs/geo/common.h: http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/common.h@28 PS8, Line 28: // see https://github.com/Esri/spatial-framework-for-hadoop/blob/v2.2.0/hive/src/main/java/com/esri/hadoop/hive/GeometryUtils.java#L21 > It'd be nice to match a tagged version here if one makes sense. Good point! Rewritten similar links to point to tags. A tag may be moved to a different version, but this seems very unlikely for past releases. http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/geospatial-functions-ir.cc File be/src/exprs/geo/geospatial-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/geospatial-functions-ir.cc@104 PS8, Line 104: // https://github.com/apache/hive/blob/rel/release-4.2.0/ql/src/java/org/apache/hadoop/hive/ql/udf/esri/ST_EnvIntersects.java#L63 > Could we refer to a tag for this as well? Done http://gerrit.cloudera.org:8080/#/c/23700/8/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java File fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java: http://gerrit.cloudera.org:8080/#/c/23700/8/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@266 PS8, Line 266: > If this fails should we fallback to loading the Java types? Or fail startup I should fail startup, not sure why I added this catch block. Removed it. -- To view, visit http://gerrit.cloudera.org:8080/23700 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ff950a25320549290a83a3b1c31ce828dd68e3c Gerrit-Change-Number: 23700 Gerrit-PatchSet: 9 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 05 Dec 2025 14:35:48 +0000 Gerrit-HasComments: Yes
