Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23700 )
Change subject: IMPALA-14573: port critical geospatial functions to c++ (part 1) ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/23700/6/be/src/exprs/geo/common.h File be/src/exprs/geo/common.h: http://gerrit.cloudera.org:8080/#/c/23700/6/be/src/exprs/geo/common.h@28 PS6, Line 28: // see https://github.com/Esri/spatial-framework-for-hadoop/blob/7226df6/hive/src/main/java/com/esri/hadoop/hive/GeometryUtils.java#L21 > nit: Can shorten slightly to https://github.com/Esri/spatial-framework-for- Done http://gerrit.cloudera.org:8080/#/c/23700/6/be/src/exprs/geo/shape-format.h File be/src/exprs/geo/shape-format.h: http://gerrit.cloudera.org:8080/#/c/23700/6/be/src/exprs/geo/shape-format.h@36 PS6, Line 36: // see https://github.com/Esri/spatial-framework-for-hadoop/blob/7226df6/hive/src/main/java/com/esri/hadoop/hive/GeometryUtils.java#L16 > line too long (168 > 90) Done http://gerrit.cloudera.org:8080/#/c/23700/6/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java File fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java: http://gerrit.cloudera.org:8080/#/c/23700/6/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@74 PS6, Line 74: boolean addNatives = true; > Is this mean to be a backend flag where you can switch on-off for experimen yes, see https://gerrit.cloudera.org/#/c/20602/6/be/src/common/global-flags.cc for the new flag I added it because I assumed that there will be behavior changes between the two libs, but it may turn out that there won't be serious ones http://gerrit.cloudera.org:8080/#/c/23700/6/tests/query_test/test_geospatial_functions.py File tests/query_test/test_geospatial_functions.py: http://gerrit.cloudera.org:8080/#/c/23700/6/tests/query_test/test_geospatial_functions.py@27 PS6, Line 27: def add_test_dimensions(cls): : super(TestGeospatialFuctions, cls).add_test_dimensions() > Might add following as well. Done http://gerrit.cloudera.org:8080/#/c/23700/6/tests/query_test/test_geospatial_functions.py@45 PS6, Line 45: f > flake8: W292 no newline at end of file Done -- To view, visit http://gerrit.cloudera.org:8080/23700 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ff950a25320549290a83a3b1c31ce828dd68e3c Gerrit-Change-Number: 23700 Gerrit-PatchSet: 8 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 27 Nov 2025 13:18:38 +0000 Gerrit-HasComments: Yes
