Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23700 )
Change subject: IMPALA-14573: port critical geospatial functions to c++ (part 1) ...................................................................... Patch Set 10: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/CMakeLists.txt File be/src/exprs/geo/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/CMakeLists.txt@29 PS8, Line 29: if (BUILD_WITH_NO_TESTS) > The original patch had no IR files too: Ack http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/shape-format.h File be/src/exprs/geo/shape-format.h: http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/shape-format.h@255 PS8, Line 255: // TODO: fix Z/M/ZM types and move to a function called from DCHECK > Yes, proper handling of Z/M coordinates in header is my next goal once this Ack http://gerrit.cloudera.org:8080/#/c/23700/8/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java File fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java: http://gerrit.cloudera.org:8080/#/c/23700/8/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@266 PS8, Line 266: > I should fail startup, not sure why I added this catch block. Removed it. Ack -- To view, visit http://gerrit.cloudera.org:8080/23700 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ff950a25320549290a83a3b1c31ce828dd68e3c Gerrit-Change-Number: 23700 Gerrit-PatchSet: 10 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 05 Dec 2025 16:33:29 +0000 Gerrit-HasComments: Yes
