Raghav Jindal has posted comments on this change. ( http://gerrit.cloudera.org:8080/23730 )
Change subject: IMPALA-14566: Add euclidean_distance and cosine_similarity functions for ARRAY<FLOAT> ...................................................................... Patch Set 7: > Uploaded patch set 7. This patch set includes all the below changes as suggested :- 1) Added a helper function ValidatingVectors to replace deduplication of same logic present in both euclid and cosine functions . Included the substitue.h and namespace strings taking reference and maintaining consistency with utility-functions-ir.cc . Also didn't added this function as static and declaring func signature in header file similar to the previous header functions I added. 2) Added #pragma once replacing the 3 lines of code #ifndef/#define names , a more simpler and cleaner way to prevent redefinition errors. 3) Corrected Comment Followed and grammar , changed to lowercase and replaced are with is. 4)Removed empty VectorDistancePrepare and Close functions. I will be pushing one more patch by eod today for both the unit and e2e test cases. -- To view, visit http://gerrit.cloudera.org:8080/23730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id305acc87530d5d0e53613fe8df9a631ea4e1080 Gerrit-Change-Number: 23730 Gerrit-PatchSet: 7 Gerrit-Owner: Raghav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Raghav Jindal <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 05 Dec 2025 04:06:20 +0000 Gerrit-HasComments: No
