Raghav Jindal has posted comments on this change. ( http://gerrit.cloudera.org:8080/23730 )
Change subject: IMPALA-14566: Add euclidean_distance and cosine_similarity functions for ARRAY<FLOAT> ...................................................................... Patch Set 5: (1 comment) > (5 comments) http://gerrit.cloudera.org:8080/#/c/23730/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23730/5//COMMIT_MSG@16 PS5, Line 16: > I think we can add some tests. One place maybe be/src/exprs/expr-test.cc Yes , I am working on adding both unit and e2e test cases. I am going through some examples already present in expr-test.cc and query_test/test_exprs.py . -- To view, visit http://gerrit.cloudera.org:8080/23730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id305acc87530d5d0e53613fe8df9a631ea4e1080 Gerrit-Change-Number: 23730 Gerrit-PatchSet: 5 Gerrit-Owner: Raghav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Raghav Jindal <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 03 Dec 2025 10:46:06 +0000 Gerrit-HasComments: Yes
